From 0288146c64f6e3fc1c1ed3958c6430f71e499baa Mon Sep 17 00:00:00 2001 From: Emanuel Zienecker Date: Wed, 14 Apr 2021 08:38:52 +0200 Subject: [PATCH] ISSUE-20: Implement review remarks --- README.adoc | 2 +- changelog.adoc | 2 +- .../kafka/health/KafkaHealthCheckCacheProperties.java | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/README.adoc b/README.adoc index 84da55b..3834890 100644 --- a/README.adoc +++ b/README.adoc @@ -81,7 +81,7 @@ Now if you call the actuator endpoint `actuator/health` you should see the follo |kafka.health.sendReceiveTimeout |2.5s | The maximum time, given as https://docs.spring.io/spring-boot/docs/2.1.9.RELEASE/reference/html/boot-features-external-config.html#boot-features-external-config-conversion-duration[Duration], to wait for sending and receiving the message. |kafka.health.pollTimeout |200ms | The time, given as https://docs.spring.io/spring-boot/docs/2.1.9.RELEASE/reference/html/boot-features-external-config.html#boot-features-external-config-conversion-duration[Duration], spent fetching the data from the topic |kafka.health.subscriptionTimeout |5s | The maximum time, given as https://docs.spring.io/spring-boot/docs/2.1.9.RELEASE/reference/html/boot-features-external-config.html#boot-features-external-config-conversion-duration[Duration], to wait for subscribing to topic -|kafka.health.cache.maximum-size |200 | Specifies the maximum number of entries the cache may contain. +|kafka.health.cache.maximumSize |200 | Specifies the maximum number of entries the cache may contain. |=== diff --git a/changelog.adoc b/changelog.adoc index bfc8cf6..e18e6b4 100644 --- a/changelog.adoc +++ b/changelog.adoc @@ -9,7 +9,7 @@ (https://github.com/deviceinsight/kafka-health-check/issues/17[ISSUE-17]) * As of now, cache metrics can be exposed. For this purpose, a corresponding MeterRegistry instance must be passed when instantiating the Kafka Health Check. (https://github.com/deviceinsight/kafka-health-check/issues/20[ISSUE-20]) -* The cache size can now be configure via the property `kafka.health.cache.maximum-size`. +* The cache size can now be configured via the property `kafka.health.cache.maximum-size`. The default value for the cache size is 200. (https://github.com/deviceinsight/kafka-health-check/issues/22[ISSUE-22]) == Version 1.2.0 diff --git a/src/main/java/com/deviceinsight/kafka/health/KafkaHealthCheckCacheProperties.java b/src/main/java/com/deviceinsight/kafka/health/KafkaHealthCheckCacheProperties.java index a929554..715e41a 100644 --- a/src/main/java/com/deviceinsight/kafka/health/KafkaHealthCheckCacheProperties.java +++ b/src/main/java/com/deviceinsight/kafka/health/KafkaHealthCheckCacheProperties.java @@ -14,6 +14,6 @@ public class KafkaHealthCheckCacheProperties { @Override public String toString() { - return "CacheProperties{" + "maximumSize=" + maximumSize + '}'; + return "CacheProperties{maximumSize=" + maximumSize + '}'; } }