From 7dd00ef97de33e0e496e796487d7e62301aa1549 Mon Sep 17 00:00:00 2001
From: bvn13 <v.boyko@profeelab.net>
Date: Wed, 14 Jul 2021 18:21:14 +0300
Subject: [PATCH] improving after review

---
 .gitmodules   |  3 ---
 README.md     | 20 ++++----------------
 build.sh      |  7 +------
 kafkacat      |  1 -
 kafkacat.spec |  5 +++--
 5 files changed, 8 insertions(+), 28 deletions(-)
 delete mode 100644 .gitmodules
 delete mode 160000 kafkacat

diff --git a/.gitmodules b/.gitmodules
deleted file mode 100644
index 4f08da9..0000000
--- a/.gitmodules
+++ /dev/null
@@ -1,3 +0,0 @@
-[submodule "kafkacat"]
-	path = kafkacat
-	url = https://github.com/edenhill/kafkacat.git
diff --git a/README.md b/README.md
index 4fdfaaa..96a6e6e 100644
--- a/README.md
+++ b/README.md
@@ -30,31 +30,19 @@ This is a Fedora package repository of [kafkacat](https://github.com/edenhill/ka
 git clone https://github.com/bvn13/kafkacat.git
 ```
 
-2. update submodule
+2. download dependencies
 
 ```
-git submodule foreach git pull origin master
+spectool -g kafkacat.spec
 ```
 
-3. make a symlink
-
-```
-ln -sf kafkacat kafkacat-1.7.0
-```
-
-4. make a tar archive
-
-```
-tar -cf kafkacat-1.7.0.tar kafkacat-1.7.0
-```
-
-5. build fedora package
+3. build fedora package
 
 ```
 fedpkg --release f34 local
 ```
 
-6. install built rpm
+4. install built rpm
 
 ```
 # rpm -i x86_64/kafkacat-1.7.0-1.x86_64.rpm
diff --git a/build.sh b/build.sh
index f6701af..6908df4 100755
--- a/build.sh
+++ b/build.sh
@@ -1,9 +1,4 @@
 #/bin/bash
 
-git submodule foreach git pull origin master
-
-ln -sf kafkacat kafkacat-1.7.0
-
-tar -cf kafkacat-1.7.0.tar kafkacat-1.7.0
-
+spectool -g kafcacat.spec
 fedpkg --release f34 local
diff --git a/kafkacat b/kafkacat
deleted file mode 160000
index b104319..0000000
--- a/kafkacat
+++ /dev/null
@@ -1 +0,0 @@
-Subproject commit b10431980d2d9b6d75f85d2779b36538f1d315a1
diff --git a/kafkacat.spec b/kafkacat.spec
index 215fade..b0bb497 100644
--- a/kafkacat.spec
+++ b/kafkacat.spec
@@ -1,11 +1,12 @@
 Name: kafkacat
-Version: 1.7.0
+Version: 1.6.0
 Release: 1%{?dist}
 Summary: kafkacat is a generic non-JVM producer and consumer for Apache Kafka 0.8, think of it as a netcat for Kafka.
 
 License:  BSD-2-Clause
 URL:      https://github.com/edenhill/kafkacat
-Source:   kafkacat-%{version}.tar
+#Source:   kafkacat-%{version}.tar
+Source:   https://github.com/edenhill/kafkacat/archive/refs/tags/1.6.0.zip
 
 BuildRequires: zlib-devel
 BuildRequires: gcc >= 4.1