review

kafkacat.spec

@@ -3,14 +3,13 @@ Version: 1.7.0
 Release: 1%(?dist)
 Summary: kafkacat is a generic non-JVM producer and consumer for Apache Kafka 0.8, think of it as a netcat for Kafka.
 
-Group:    Productivity/Networking/Other
 License:  BSD-2-Clause
 URL:      https://github.com/edenhill/kafkacat
 Source:   kafkacat-%{version}.tar
-Requires: librdkafka
 
-BuildRequires: zlib-devel gcc >= 4.1 librdkafka-devel
-BuildRoot: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)
+BuildRequires: zlib-devel
+BuildRequires: gcc >= 4.1
+BuildRequires: librdkafka-devel
 
 %description
 kafkacat is a generic non-JVM producer and consumer for Apache Kafka >= 0.8,
@@ -29,26 +28,19 @@ of the Kafka cluster and its topics and partitions.
 kafkacat is fast and lightweight; statically linked it is no more than 150Kb.
 
 %prep
-%setup -q
+%autosetup
 
 %configure
-#./configure
-./configure --prefix=/usr
 
 %build
-make
+%make_build
 
 %install
-rm -rf %{buildroot}
-DESTDIR=%{buildroot} make install
+%make_install
 
-%clean
-rm -rf %{buildroot}
-
-%files -n %{name}
-%defattr(755,root,root)
+%files
 %{_bindir}/kafkacat
-%defattr(644,root,root)
-%doc README.md
-%doc LICENSE
 
+%doc README.md
+%license LICENSE
+%changelog CHANGELOG.md